-
-
Notifications
You must be signed in to change notification settings - Fork 557
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add missing attributes to launch template, remove null resource for tag propagation, propagate default tags to instances, allow propagated name to be set independently of ASG #169
feat: add missing attributes to launch template, remove null resource for tag propagation, propagate default tags to instances, allow propagated name to be set independently of ASG #169
Conversation
… for tag propagation, proagate default tags to instances, allow propagated name to be set independently of ASG - Add additional attributes that have been added to the launch template specification lately - Remove the null resource for updating propagated tags; replace with a list comprehension expression that achieves the same result - Add default tags data source and add in default tags to propagated tags: closes #162 - Add new variable `instance_name` that allows users to set the propagated instance name independently of the ASG `var.name`; if not specified it defaults to current `var.name`: closes #158 - Make the attribute `block_duration_minutes` option under `spot_options` - this is still supported in the AWS provider but by making this optional it will fix/close #156
Co-authored-by: Anton Babenko <[email protected]>
Co-authored-by: Anton Babenko <[email protected]>
@antonbabenko this one should be ready if you have some time |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost perfect.
PS: Feel free to push PRs for the semantic-release to all other modules if you have time. Let's finish them during this week.
# [4.9.0](v4.8.1...v4.9.0) (2021-11-22) ### Features * add missing attributes to launch template, remove null resource for tag propagation, propagate default tags to instances, allow propagated name to be set independently of ASG ([#169](#169)) ([f14ca13](f14ca13))
This PR is included in version 4.9.0 🎉 |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Description
instance_name
that allows users to set the propagated instance name independently of the ASGvar.name
; if not specified it defaults to currentvar.name
: closes Since 4.0.0 the ASG name is used to fill the EC2 "Name" tag #158block_duration_minutes
option underspot_options
- this is still supported in the AWS provider but by making this optional it will fix/close spot instances no longer support block duration #156Motivation and Context
Breaking Changes
No, but users will see some updates in their plans with the switch from null resource to list comprehension of propagated tags
How Has This Been Tested?
examples/*
projectscomplete
example onmaster
and switched to this branch and verified changes and diffs