feat: add missing attributes to launch template, remove null resource for tag propagation, propagate default tags to instances, allow propagated name to be set independently of ASG #169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… for tag propagation, proagate default tags to instances, allow propagated name to be set independently of ASG - Add additional attributes that have been added to the launch template specification lately - Remove the null resource for updating propagated tags; replace with a list comprehension expression that achieves the same result - Add default tags data source and add in default tags to propagated tags: closes #162 - Add new variable `instance_name` that allows users to set the propagated instance name independently of the ASG `var.name`; if not specified it defaults to current `var.name`: closes #158 - Make the attribute `block_duration_minutes` option under `spot_options` - this is still supported in the AWS provider but by making this optional it will fix/close #156
Co-authored-by: Anton Babenko <[email protected]>
Co-authored-by: Anton Babenko <[email protected]>
|
@antonbabenko this one should be ready if you have some time |
antonbabenko
pushed a commit
that referenced
this pull request
Nov 22, 2021
# [4.9.0](v4.8.1...v4.9.0) (2021-11-22) ### Features * add missing attributes to launch template, remove null resource for tag propagation, propagate default tags to instances, allow propagated name to be set independently of ASG ([#169](#169)) ([f14ca13](f14ca13))
|
This PR is included in version 4.9.0 🎉 |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
instance_namethat allows users to set the propagated instance name independently of the ASGvar.name; if not specified it defaults to currentvar.name: closes Since 4.0.0 the ASG name is used to fill the EC2 "Name" tag #158block_duration_minutesoption underspot_options- this is still supported in the AWS provider but by making this optional it will fix/close spot instances no longer support block duration #156Motivation and Context
Breaking Changes
No, but users will see some updates in their plans with the switch from null resource to list comprehension of propagated tags
How Has This Been Tested?
examples/*projectscompleteexample onmasterand switched to this branch and verified changes and diffs